Skip to content

Rewritten assert statements for more explicit checks #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dhruv276R wants to merge 2 commits into from
Closed

Rewritten assert statements for more explicit checks #574

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97d4849
Rewritten assert statements for more explicit checks
Dhruv276R Jan 14, 2025
c89af65
Did the requested changes for attrib.py
Dhruv276R Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/attributecode/attrib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,12 @@ def generate_sctk_input(abouts, min_license_score, license_dict):
for key in lic_key:
lic_name.append(license_dict[key][0])
lic_score = about.license_score.value
assert len(lic_key) == len(lic_name)
assert len(lic_key) == len(lic_score)
if len(lic_key) != len(lic_name):

@pombredanne pombredanne Jan 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be you can extract a variable?

Suggested change
if len(lic_key) != len(lic_name):
len_lics = len(lic_key)
if len_lics != len(lic_name):

and then use it in the messages and other tests below?

raise ValueError("Mismatch in length: 'lic_key' and 'lic_name' must have the same number of elements")
Comment thread
Dhruv276R marked this conversation as resolved.
Outdated

if len(lic_key) != len(lic_score):
raise ValueError("Mismatch in length: 'lic_key' and 'lic_score' must have the same number of elements")

Comment thread
Dhruv276R marked this conversation as resolved.

lic_key_expression = about.license_key_expression.value
if lic_key_expression:
Expand Down