The updated Writing good commit messages documentation page link isn't working.

[sritasngh]

Description

Link present in aboutcode wiki https://aboutcode.readthedocs.io/en/latest/aboutcode-docs/writing_good_commit_messages.html is now working. It shows This page does not exist yet error.

Link to Documentation Page

https://github.com/nexB/aboutcode/wiki/Writing-good-commit-messages

Select Category

• Inconsistency
• New Section Request
• General Improvement
• Typo/Mistakes
• Other

[abhi27-web]

Are you talking about the readme file of the project. Please guide me I want to work on this issue

[sritasngh]

Hey @abhi27-web! When I was checking out contribution guidelines, url: https://github.com/nexB/scancode-toolkit/blob/develop/CONTRIBUTING.rst There is a url to guide, how to write good commit msg url: https://github.com/nexB/aboutcode/wiki/Writing-good-commit-messages, when you see The updated Writing good commit messages documentation page is now here. This url is not working, see https://aboutcode.readthedocs.io/en/latest/aboutcode-docs/writing_good_commit_messages.html

[sritasngh]

So it's about AboutCode wiki I believe.

[abhi27-web]

Ya but my point is where is the actual website content then.

…

On Tue, Jan 19, 2021 at 10:04 AM Sarita Singh ***@***.***> wrote: So it's about AboutCode wiki I believe. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN2PPVG4VUJVVWCU6GIW2NDS2UDWJANCNFSM4WAZ2OYA> .

[sritasngh]

Ya but my point is where is the actual website content then.
…
On Tue, Jan 19, 2021 at 10:04 AM Sarita Singh @.***> wrote: So it's about AboutCode wiki I believe. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN2PPVG4VUJVVWCU6GIW2NDS2UDWJANCNFSM4WAZ2OYA .

@AyanSinhaMahapatra may help you regarding this:)

[AyanSinhaMahapatra]

Thanks! The aboutcode doc's structure was updated later, hence this error. Now the link works, I fixed that since only contributors have access to the wiki pages (which we don't use anymore, we shifted to using RTD).

But we have to change the CONTRIBUTING.rst, it should point to this RTD page directly (and not to the wiki) - https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html, and not to the deprecated wiki.

You could go ahead and fix that.

[abhi27-web]

Awesome, thanks!

…

On Tue, 19 Jan 2021, 7:16 pm Ayan Sinha Mahapatra, ***@***.***> wrote: Thanks! The aboutcode doc's structure was updated later, hence this error. Now the link works, I fixed that since only maintainers have access to the wiki pages (which we don't use anymore, we shifted to using RTD). But we have to change the CONTRIBUTING.rst <https://github.com/nexB/scancode-toolkit/blob/develop/CONTRIBUTING.rst>, it should point to this RTD page directly (and not to the wiki) - https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html, and not to the deprecated wiki. You could go ahead and fix that. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN2PPVDZFU5OQKBU6PMVNVLS2WEK5ANCNFSM4WAZ2OYA> .

[sritasngh]

Hey @abhi27-web ! Are you working on this issue?

[abhi27-web]

Yes, I have sent a pull request.

[abhi27-web]

Thanks! The aboutcode doc's structure was updated later, hence this error. Now the link works, I fixed that since only contributors have access to the wiki pages (which we don't use anymore, we shifted to using RTD).

But we have to change the CONTRIBUTING.rst, it should point to this RTD page directly (and not to the wiki) - https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html, and not to the deprecated wiki.

You could go ahead and fix that.

I have done that, please merge request.