Skip to content

Add doc8 style checks to Travis-CI - #30

Merged
steven-esser merged 3 commits into
aboutcode-org:masterfrom
AyanSinhaMahapatra:CI-upgrade
Nov 1, 2019
Merged

Add doc8 style checks to Travis-CI#30
steven-esser merged 3 commits into
aboutcode-org:masterfrom
AyanSinhaMahapatra:CI-upgrade

Conversation

@AyanSinhaMahapatra

@AyanSinhaMahapatra AyanSinhaMahapatra commented Oct 22, 2019

Copy link
Copy Markdown
Member

Refer : What Is Checked

Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com

@AyanSinhaMahapatra
AyanSinhaMahapatra force-pushed the CI-upgrade branch 2 times, most recently from 54321d1 to 485ff77 Compare October 22, 2019 21:34
@AyanSinhaMahapatra

AyanSinhaMahapatra commented Oct 22, 2019

Copy link
Copy Markdown
Member Author

Please close the PR #29 before, or Travis will fail on this.

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline questions

Comment thread docs/scripts/doc8_style_check.sh Outdated

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tickets are added for the doc8 checks, this should be good to go.

Comment thread docs/scripts/doc8_style_check.sh Outdated
@AyanSinhaMahapatra

Copy link
Copy Markdown
Member Author

@MaJuRG I pushed this commit fixing all doc style Errors. I've also pushed changes on this branch so that doc8 tests run on all the docs.

@steven-esser

Copy link
Copy Markdown
Contributor

This looks good to me. Will get this merged once #29 is merged.

@steven-esser

Copy link
Copy Markdown
Contributor

@AyanSinhaMahapatra Can you rebase this and push again so the build passes?

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra

Copy link
Copy Markdown
Member Author

@MaJuRG Done!

@steven-esser
steven-esser merged commit 7229d3e into aboutcode-org:master Nov 1, 2019
@AyanSinhaMahapatra
AyanSinhaMahapatra deleted the CI-upgrade branch November 1, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants