Skip to content

Update contributing.rst - #56

Closed
ghost wants to merge 1 commit into
masterfrom
unknown repository
Closed

Update contributing.rst#56
ghost wants to merge 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Dec 5, 2020

Copy link
Copy Markdown

Fixes #55

Tasks

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
    This is commit message
    Signed-off-by : akshaydayma akshaydayma50@gmail.com

@ghost

ghost commented Dec 11, 2020

Copy link
Copy Markdown
Author

Fixes #55

Tasks

  • PR is descriptively titled bookmark_tabs and links the original issue above link
  • Tests pass -- look for a green checkbox heavy_check_mark a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts file_folder
    This is commit message
    Signed-off-by : akshaydayma akshaydayma50@gmail.com

@ghost ghost closed this Dec 11, 2020
@ghost

ghost commented Dec 11, 2020

Copy link
Copy Markdown
Author

Fixes #55

Tasks

  • PR is descriptively titled bookmark_tabs and links the original issue above link
  • Tests pass -- look for a green checkbox heavy_check_mark a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts file_folder
    This is commit message
    Signed-off-by : akshaydayma akshaydayma50@gmail.com

@ghost ghost reopened this Dec 11, 2020

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshaydayma A few questions:

  1. What was the purpose of these changes? Your commit message does not explain why you made the changes you made.
  2. You are missing a git commit sign off. Please rebase your commit and include this sign-off.
  3. You have a few formatting errors, show in the Travis Build for this PR here: https://travis-ci.org/github/nexB/aboutcode/builds/749029147

@ghost ghost closed this Dec 21, 2020
AyanSinhaMahapatra pushed a commit that referenced this pull request Mar 30, 2022
Add black codestyle test for skeleton
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant