Skip to content

Update testing.rst - #57

Closed
ghost wants to merge 2 commits into
masterfrom
unknown repository
Closed

ghost wants to merge 2 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Dec 6, 2020

Copy link
Copy Markdown

#57
Signed-off-by: Akshay Daymaakshaydayma50@gmail.com

@ghost

ghost commented Dec 6, 2020

Copy link
Copy Markdown
Author

Respected Sir/Madam, I shared my contribution please check and merge it .
@pombredanne
@tdruez
@chinyeungli @mjherzog @farialima

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshaydayma A few questions:

  1. What was the purpose of these changes? You commit message does not explain why you made the changes you made.
  2. You are missing a git commit sign off. Please rebase your commit to include the sign-off
  3. You have a few formatting errors, show in the Travis Build for this PR here: https://travis-ci.org/github/nexB/aboutcode/builds/748115814

@ghost ghost closed this Dec 21, 2020
@ghost ghost reopened this Dec 21, 2020
@ghost ghost closed this Dec 21, 2020
@ghost ghost reopened this Dec 28, 2020
@steven-esser

Copy link
Copy Markdown
Contributor

Closing this as stale.

AyanSinhaMahapatra pushed a commit that referenced this pull request Mar 30, 2022
Deprecate windows-2016 images for azure CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant