Bring back module level variables - #10
Conversation
|
@priv-kweihmann Good catch! If you need these let me reinstate them. Eventually they should not longer be needed by the updates to ScanCode in this branch that are about to be merged anytime: aboutcode-org/scancode-toolkit#2365 |
| def logger_debug(*args): | ||
| return logger.debug(' '.join(isinstance(a, str) and a or repr(a) for a in args)) | ||
|
|
||
| PATH_TYPE = compat.unicode |
There was a problem hiding this comment.
Note that compat is gone entirely and compat.unicode can just be replaced by str
Alright, if something else unbreaks scancode I'm also fine with it - Let the first MR win :-) |
0c646b7 removed several module level variables, although they are needed by downstream tools like scancode. Bring them back in their py3 only variants Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
to avoid future regressions Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
59ec98d to
b635599
Compare
|
On a second thought, I think this still should be merged, as otherwise we will still have downstream users (current released scancode) that does pulls the current version of commoncode automatically via pip. |
|
@priv-kweihmann I wanted to merge this still. I needed to push a release first. Do you think this is no longer an issue with the latest release? |
|
I'm not having issues with the latest release in this regard (but with a lot of other things :-) ) - so IMO this MR can be closed as it isn't needed any more |
0c646b7 removed several
module level variables, although they are needed by downstream tools like scancode.
Bring them back in their py3 only variants.
Add test cases to avoid future regression