Skip to content

Raise URNValidationError for truncated URNs #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codewithfourtix wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Raise URNValidationError for truncated URNs #109

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f79b8fe
Raise URNValidationError for truncated URNs
codewithfourtix Sep 5, 2026
460b150
Address review feedback on validation and fallback coverage
codewithfourtix Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/commoncode/urn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@ def decode(urn):
"""
segments = [unquote_plus(p) for p in urn.split(":")]

if len(segments) < 3:
raise URNValidationError("Invalid URN: missing namespace or object type.")

Comment thread
codewithfourtix marked this conversation as resolved.
Outdated
if not segments[0] == ("urn"):
raise URNValidationError("Invalid URN prefix. Expected 'urn'.")

Expand Down
8 changes: 8 additions & 0 deletions tests/test_urn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,3 +140,11 @@ def test_encode_decode_is_idempotent(self):
encoded = "urn:dje:component:SIP+Servlets+%28MSS%29:v+1.4.0.FINAL"
assert urn.encode(object_type, **fields) == encoded
assert urn.decode(encoded) == (object_type, fields)


class TruncatedURNTestCase(unittest.TestCase):
def test_truncated_urns_raise_validation_error(self):
for value in ("", "urn", "urn:", "urn:dje"):
with self.subTest(value=value):
with self.assertRaises(urn.URNValidationError):
urn.decode(value)