fixed TypeError due to different attributes over directories and files - #21
Merged
Merged
Conversation
pombredanne
requested changes
Jun 10, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks!
Please see my comments inline.
| @@ -1593,8 +1593,12 @@ def _populate(self, scan_data): | |||
|
|
|||
| # We collect the first Resource so we can see what attributes it has and determine | |||
Member
There was a problem hiding this comment.
Please update these comments accordingly
Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com>
pratik0316
force-pushed
the
dynamic_attrs
branch
from
June 11, 2021 02:28
5f61749 to
83a760a
Compare
pombredanne
approved these changes
Jun 11, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks. merging now
Reminder for the next PR: please also update the CHANGELOG.
Contributor
Author
|
Okay 👍 |
priv-kweihmann
pushed a commit
to priv-kweihmann/commoncode
that referenced
this pull request
Sep 15, 2021
Fix .gitattributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pratik Dey pratikrocks.dey11@gmail.com
Fix for #20