Skip to content

Do not trigger a RecursionError #23 - #24

Merged
pombredanne merged 6 commits into
mainfrom
23-recursion-error
Jun 11, 2021
Merged

Do not trigger a RecursionError #23#24
pombredanne merged 6 commits into
mainfrom
23-recursion-error

Conversation

@pombredanne

@pombredanne pombredanne commented Jun 11, 2021

Copy link
Copy Markdown
Member

We have a recursion-error when using a plain JSON from ScanCode.io scan_codebase pipeline.
This PR is to fix this #23

It also contains a supplemental fix for aboutcode-org/scancode-toolkit#1422

Signed-off-by: Philippe Ombredanne pombredanne@nexb.com

We have a recursion-error

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
pombredanne requested a review from JonoYang June 11, 2021 00:49
Signed-off-by: Jono Yang <jyang@nexb.com>
@pombredanne

Copy link
Copy Markdown
Member Author

@JonoYang Thank you ++
I created #25 as a follow up

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Fix for aboutcode-org/scancode-toolkit#1422
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne

Copy link
Copy Markdown
Member Author

Green 🍏 💚
Merging!

@pombredanne
pombredanne merged commit 452c2b5 into main Jun 11, 2021
@pombredanne
pombredanne deleted the 23-recursion-error branch June 11, 2021 13:31
priv-kweihmann pushed a commit to priv-kweihmann/commoncode that referenced this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants