Skip to content

Use shutil.get_terminal_size() - #40

Merged
AyanSinhaMahapatra merged 1 commit into
aboutcode-org:mainfrom
georgthegreat:patch-1
Apr 18, 2022
Merged

Use shutil.get_terminal_size()#40
AyanSinhaMahapatra merged 1 commit into
aboutcode-org:mainfrom
georgthegreat:patch-1

Conversation

@georgthegreat

@georgthegreat georgthegreat commented Apr 17, 2022

Copy link
Copy Markdown
Contributor

click==8.1.0 removed click.get_terminal_size()

@pombredanne

Copy link
Copy Markdown
Member

Thank you ++! that a small change, but we still use the DCO as a base... do you mind to signoff your commit? You can also just paste that in a message in this PR to the same effect.

BTW, this makes me think we should have a CI test run that uses the latest and greatest of all dependencies. Click has been a bit problematic as 8.10 may be would have been better as 9.0 ... not that this would make a big difference.

click==8.1.0 [removes](https://click.palletsprojects.com/en/8.1.x/changes/#version-8-1-0) click.get_terminal_size()

Signed-off-by: Yuriy Chernyshov <thegeorg@yandex-team.ru>
@georgthegreat

Copy link
Copy Markdown
Contributor Author

I have signed this off via git.

@AyanSinhaMahapatra

Copy link
Copy Markdown
Member

Thanks @georgthegreat !

@AyanSinhaMahapatra
AyanSinhaMahapatra merged commit 6c514bb into aboutcode-org:main Apr 18, 2022
@pombredanne

Copy link
Copy Markdown
Member

@georgthegreat Thank you.

AyanSinhaMahapatra pushed a commit to AyanSinhaMahapatra/commoncode that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants