Do not assign None to codebase attributes #48 - #49
Merged
Conversation
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
48-correctly-assign-codebase-attributes
branch
2 times, most recently
from
February 4, 2023 01:35
94707c6 to
b9bdf5f
Compare
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
48-correctly-assign-codebase-attributes
branch
from
February 4, 2023 01:36
b9bdf5f to
59c9c17
Compare
pombredanne
approved these changes
Feb 23, 2023
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM with only one small nit to fix.
Thanks!
Signed-off-by: Jono Yang <jyang@nexb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jono Yang jyang@nexb.com