Skip to content

Restrict python version for typing dependency - #5

Merged
pombredanne merged 1 commit into
aboutcode-org:mainfrom
cco3:typing
Nov 18, 2020
Merged

Restrict python version for typing dependency#5
pombredanne merged 1 commit into
aboutcode-org:mainfrom
cco3:typing

Conversation

@cco3

@cco3 cco3 commented Nov 18, 2020

Copy link
Copy Markdown
Contributor

Importing typing causes errors after python 3.6.
See python/typing#573

Importing typing causes errors after python 3.6.
See python/typing#573

Signed-off-by: Conley Owens <cco3@google.com>

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ++ LGTM, merging!

@pombredanne
pombredanne merged commit fbe882d into aboutcode-org:main Nov 18, 2020
pombredanne added a commit to aboutcode-org/scancode-toolkit that referenced this pull request Nov 18, 2020
Applying the same fix here than in
aboutcode-org/commoncode#5

Reported-by: Signed-off-by: Conley Owens <cco3@google.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@tiulpin

tiulpin commented Dec 4, 2020

Copy link
Copy Markdown

Hi! Thank you for the fix.

When do you plan to publish the new package version to PyPi?
scancode-toolkit uses commoncode as a dependency, that is why this typing issue still exists and bothers some users (including myself).

Thanks again!

@pombredanne

Copy link
Copy Markdown
Member

@tiulpin anytime now. This will be in together with a new scancode release by the middle of next week at the latest

@tiulpin

tiulpin commented Jan 13, 2021

Copy link
Copy Markdown

Hi! Any news or I missed the update?)

@pombredanne

Copy link
Copy Markdown
Member

well I was a bit too optimist :) ... we now have a branch in https://github.com/nexB/scancode-toolkit/tree/release-21-01-prep for scancode and I am moving to this here then

@pombredanne

Copy link
Copy Markdown
Member

@cco3 Thanks. All merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants