Fix virtualcodebase creation bug - #58
Merged
Merged
Conversation
Signed-off-by: Jono Yang <jyang@nexb.com>
* If an existing resource is equa lto Codebase.CACHED_RESOURCE, then create that Resource Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
fix-virtualcodebase-creation-bug
branch
from
August 25, 2023 19:36
254ba02 to
7c417a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in VirtualCodebase creation where in the case where the immediate child of the root has the same directory name as the root would cause us to prevent us from creating the codebase tree properly.