Skip to content

Remove encoding keyword argument - #7

Merged
pombredanne merged 2 commits into
mainfrom
6-encoding-keyword
Jan 14, 2021
Merged

Remove encoding keyword argument#7
pombredanne merged 2 commits into
mainfrom
6-encoding-keyword

Conversation

@tdruez

@tdruez tdruez commented Nov 19, 2020

Copy link
Copy Markdown
Contributor

Deprecated since Python version 3.1, removed in version 3.9

Signed-off-by: Thomas Druez tdruez@nexb.com

Deprecated since Python version 3.1, removed in version 3.9

Signed-off-by: Thomas Druez <tdruez@nexb.com>
Signed-off-by: Thomas Druez <tdruez@nexb.com>

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdruez Thanks! can you also add a python_requires to the setup.cfg (and change the classifiers) so that's tagged as no longer supporting Python 2?
We would also need to enable CI on 3.6 to 3.9 ... on Azure may be? at the minimum on travis for now.

@cco3 FYI

@tdruez

tdruez commented Nov 19, 2020

Copy link
Copy Markdown
Contributor Author

@pombredanne is the support for 2.7 really dropped by that change though?
I do not see any json.load calls in the ScanCode codebases that is still using the encoding argument at the moment.

@pombredanne
pombredanne merged commit 23f358f into main Jan 14, 2021
@pombredanne
pombredanne deleted the 6-encoding-keyword branch January 14, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants