Skip to content

fix whiteout opaque prefix - #39

Closed
aj-arena wants to merge 1 commit into
aboutcode-org:mainfrom
aj-arena:patch-1
Closed

aj-arena wants to merge 1 commit into
aboutcode-org:mainfrom
aj-arena:patch-1

Conversation

@aj-arena

@aj-arena aj-arena commented Jun 2, 2022

Copy link
Copy Markdown

Per - https://github.com/opencontainers/image-spec/blob/main/layer.md#whiteouts
An opaque whiteout entry is a file with the name .wh..wh..opq but code is currently missing the second second dot

Per - https://github.com/opencontainers/image-spec/blob/main/layer.md#whiteouts
An opaque whiteout entry is a file with the name `.wh..wh..opq` but code is currently missing the second second dot

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ++ ... this is a great catch!
I guess a small dot is enough to make the tests fail... Do you mind to help update them too?

@pombredanne

Copy link
Copy Markdown
Member

This made me think that we may not be handling ".wh..wh..plnk" correctly or at all... This is the opportunity to get this corrected too IMHO.

@aj-arena

aj-arena commented Jun 3, 2022

Copy link
Copy Markdown
Author

This made me think that we may not be handling ".wh..wh..plnk" correctly or at all... This is the opportunity to get this corrected too IMHO.

I do not see plnk mentioned in that file, but that format only has 1 second dot .wh..wh.plnk

@pombredanne

Copy link
Copy Markdown
Member

I do not see plnk mentioned in that file, but that format only has 1 second dot .wh..wh.plnk

Yes... that's the point! we are missing this entirely.

@pombredanne

Copy link
Copy Markdown
Member

gentle ping ... I would like to merge this soon enough ... but I cannot if we have tests failing.

@pombredanne

Copy link
Copy Markdown
Member

Never mind... I will handle this directly and make the correction in a new branch including the plnk support
Thanks!

pombredanne added a commit that referenced this pull request Jul 31, 2022
* Do not skip opaque whiteouts
* Do not treat whiteouts as relative paths
* Log error for legacy .plnk and .aufs AUFS whiteouts
* "Per
  https://github.com/opencontainers/image-spec/blob/main/layer.md#whiteouts
  An opaque whiteout entry is a file with the name .wh..wh..opq but
  code is currently missing the second second dot"

Reported-by: AJ Arena @sig-aarena
Reference: #39
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this pull request Jul 31, 2022
* Do not skip opaque whiteouts
* Do not treat whiteouts as relative paths
* Log error for legacy .plnk and .aufs AUFS whiteouts
* "Per
  https://github.com/opencontainers/image-spec/blob/main/layer.md#whiteouts
  An opaque whiteout entry is a file with the name .wh..wh..opq but
  code is currently missing the second second dot"

Reported-by: AJ Arena @sig-aarena
Reference: #39
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne

Copy link
Copy Markdown
Member

@sig-aarena FYI, this is fixed there 7ad595b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants