Adjust License Diff to account for License Category

[steven-esser]

Auditors care more about Copyleft and Proprietary licenses showing up in a codebase. We need to adjust our scoring so that more emphasis is give to:

• 'no license' -> 'copyleft limited or higher'
• 'permissive' -> 'copyleft limited or higher'
• 'anything -> 'proprietary/commercial'

There are probably other combinations here as well.

[steven-esser]

You may want to break this up into small tickets if needed.

[johnmhoran]

@MaJuRG @DennisClark I'm looking for several large codebases to test my license-change detection work and thought the recent Facebook change to its React licensing might be useful.

Testing react-16.0.0 against react-15.6.1, it appears from the DeltaCode output that the license in question might have the ScanCode key facebook-patent-rights-2 (category: Permissive). However, if I paste that key into a DejaCode Licenses search, the only license returned is antlr-pd.

• Is facebook-patent-rights-2 not listed in DejaCode, or (perhaps more likely) am I searching incorrectly?
• Assuming the license in question is in fact facebook-patent-rights-2, I'm curious why we treat it as Permissive when it created such an uproar.
• Last but not least, can you suggest one or two codebases in which there were changes from Permissive (or no license at all) to Copyleft Limited, Copyleft or some other more-restrictive license?

[DennisClark]

@jmhoran once again, scancode is “ahead of” dejacode. Please create a new license request in DejaCode.

[johnmhoran]

@DennisClark Is that done by opening a new issue and assigning the label license_library?

[steven-esser]

@johnmhoran that license may not be in DejaCode, or if it is, it is under a slightly different name.

As far as single projects that change from permissive to copyleft, I do not know many off the top of my head. You may have to craft these specific examples.

[johnmhoran]

@MaJuRG Thanks -- will do. And thanks as well re how to create a license request.

[johnmhoran]

@MaJuRG I'm in DejaCode -- is the license request submitted through the https://dejacode.zendesk.com/hc/en-us/requests/new URL (a "Submit a request" form)?

[steven-esser]

No, go here: https://enterprise.dejacode.com/requests/

[johnmhoran]

Thanks @MaJuRG -- request submitted.

[johnmhoran]

@MaJuRG In one of your three examples above, 'permissive' -> 'copyleft limited or higher', how do you want to treat the delta if the old file has both 'permissive' and 'public domain'? They seem sufficiently similar in contrast to the 'copyleft limited or higher' group that I suggest we modify this to 'permissive' and/pr 'public domain' -> 'copyleft limited or higher'.

What do you think?