Similarity Matching by Fingerprint Comparison. - #128
Conversation
steven-esser
left a comment
There was a problem hiding this comment.
Initial comments left.
This is a good start. You will of course have to write tests and fix the current failures, but this is good progress.
steven-esser
left a comment
There was a problem hiding this comment.
Good job on the addressing most of the previous changes. See my comments relating to the similarity() function.
Once you address those and add robust integration tests, we can review further.
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
steven-esser
left a comment
There was a problem hiding this comment.
See my comments. We probably do not need to copy over the whole file from scancode. We only really need the function that checks two JSON files, correct?
Also, you have not added any tests yet so there is not much else for me to review.
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
steven-esser
left a comment
There was a problem hiding this comment.
Just some minor changes at this time. If we are going to keep the test_utils in their own file, can we just put it under the tests/ directory?
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.