Skip to content

Similarity Matching by Fingerprint Comparison. - #128

Merged
steven-esser merged 10 commits into
aboutcode-org:developfrom
arnav-mandal1234:gsoc_similarity_matching
Aug 28, 2019
Merged

Similarity Matching by Fingerprint Comparison.#128
steven-esser merged 10 commits into
aboutcode-org:developfrom
arnav-mandal1234:gsoc_similarity_matching

Conversation

@arnav-mandal1234

@arnav-mandal1234 arnav-mandal1234 commented Aug 9, 2019

Copy link
Copy Markdown
Collaborator
  • Implementation of distance finding algorithm between the files and process them further.
  • Integration of fingerprint field in the JSON file to compare the deltas and provide them with appropriate scores.
  • Modification of old unit tests
  • Addition of new unit tests

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments left.

This is a good start. You will of course have to write tests and fix the current failures, but this is good progress.

Comment thread src/deltacode/__init__.py Outdated
Comment thread src/deltacode/__init__.py Outdated
Comment thread src/deltacode/__init__.py Outdated

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on the addressing most of the previous changes. See my comments relating to the similarity() function.

Once you address those and add robust integration tests, we can review further.

Comment thread src/deltacode/__init__.py Outdated
Comment thread src/deltacode/__init__.py Outdated
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments. We probably do not need to copy over the whole file from scancode. We only really need the function that checks two JSON files, correct?

Also, you have not added any tests yet so there is not much else for me to review.

Comment thread src/deltacode/__init__.py Outdated
Comment thread src/deltacode/utils.py Outdated
Comment thread src/deltacode/cli_test_utils.py Outdated
Comment thread src/deltacode/cli_test_utils.py
Comment thread src/deltacode/__init__.py Outdated
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes at this time. If we are going to keep the test_utils in their own file, can we just put it under the tests/ directory?

Comment thread tests/test_deltacode.py Outdated
Comment thread tests/test_deltacode.py Outdated
Comment thread tests/test_deltacode.py Outdated
Comment thread src/deltacode/cli_test_utils.py
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>

@JonoYang JonoYang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. It looks good, please look at my changes so the tests work properly

Comment thread tests/test_deltacode.py Outdated
Comment thread tests/test_deltacode.py Outdated
Comment thread tests/test_deltacode.py Outdated
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
@steven-esser
steven-esser merged commit 6778882 into aboutcode-org:develop Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants