Update .gitignore and Add limited delta status on cli - #138
Closed
ankit2001 wants to merge 1 commit into
Closed
Conversation
Author
|
I have created new pr @MaJuRG , please review it . |
steven-esser
suggested changes
Mar 15, 2020
| /Scripts | ||
| /Lib | ||
| /pip-selfcheck.json | ||
| /output.json |
Contributor
There was a problem hiding this comment.
We do not want this in our gitignore
Contributor
There was a problem hiding this comment.
You did not remove this yet.
steven-esser
suggested changes
Mar 16, 2020
| /Scripts | ||
| /Lib | ||
| /pip-selfcheck.json | ||
| /output.json |
Contributor
There was a problem hiding this comment.
You did not remove this yet.
Signed-off-by: ankit2001 <ankitchoudhary202.ac@gmail.com>
Author
|
@MaJuRG ,i have done the required changes. |
steven-esser
suggested changes
Mar 20, 2020
Comment on lines
+60
to
+63
| status = deltacode.stats.to_dict() | ||
| click.echo("\nDelta stats :\n") | ||
| for stat, value in status.iteritems(): | ||
| click.echo("{} : {}".format(stat,value)) |
Contributor
There was a problem hiding this comment.
Can we break down the stats to handle factors as well?
Author
There was a problem hiding this comment.
what factors u want @MaJuRG, can u give me some examples??
Contributor
|
Closing due to stagnation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ankit2001 ankitchoudhary202.ac@gmail.com