Skip to content

Some basic refacting in doc strings and syntax - #165

Closed
pratik0316 wants to merge 2 commits into
aboutcode-org:developfrom
pratik0316:fix_test_empty
Closed

Some basic refacting in doc strings and syntax#165
pratik0316 wants to merge 2 commits into
aboutcode-org:developfrom
pratik0316:fix_test_empty

Conversation

@pratik0316

Copy link
Copy Markdown
Collaborator

Signed-off-by: Pratik Dey pratikrocks.dey11@gmail.com

Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com>
Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com>
@pratik0316 pratik0316 changed the title fixed test_cli.py:TestCLI::test_empty and some basic refacting Some basic refacting in doc strings and syntax Mar 19, 2021
Comment thread src/deltacode/__init__.py
SIMILARITY_LIMIT = 35

class DeltaCode(object):
class DeltaCode:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(object) no longer needed in py3

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pratikrocks Not sure if this is just a test PR or similar, but in general we would reject a PR like this. Very tiny formatting and syntax changes are not enough for a PR contribution.

@pratik0316

Copy link
Copy Markdown
Collaborator Author

Ok @MaJuRG closing it, will add it later with some useful PR

@pratik0316 pratik0316 closed this Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants