Add notice etc. to JSON output, collect errors #6 #46 - #50
Merged
Merged
Conversation
* Create notice file, collect options selections, add to JSON output
via cli.py.
* Refactor version code, add to __init__.py and setup.py.
* Modify existing tests to test changes.
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
* Add 'options' attribute to 'DeltaCode' object. * Fix failing tests, refactor other tests to test new structure. Signed-off-by: John M. Horan <johnmhoran@gmail.com>
* Consolidate custom exceptions as 'ScancodeException()'.
* Pass informative message reflecting circumstances in which exception
was raised.
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
* Add filename to exception message. * Delete redundant 'ScancodeException:' from error message. * Modify tests. Signed-off-by: John M. Horan <johnmhoran@gmail.com>
* Merged branch '6-collect-errors' into 46-add-notice-to-json-output-file to work on both at the same time. Signed-off-by: John M. Horan <johnmhoran@gmail.com>
* Rename custom exception. * Use path rather than filename in custom exception messages. * Simplify retrieval/generation of version info. * Create utility to retrieve notice info. Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: Steven Esser <sesser@nexb.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: Steven Esser <sesser@nexb.com>
Signed-off-by: Steven Esser <sesser@nexb.com>
steven-esser
approved these changes
Feb 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.