Flatten DeltaCode.deltas field #59 - #66
Merged
Merged
Conversation
* Scores are added in 'DeltaCode.determine_delta()',
'DeltaCode.update_deltas()' and 'Delta._license_diff()'.
* Refactored 11 failing tests.
* JSON output tackled, but CSV output not yet tackled -- will be next.
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
* Also refactored 15 failing tests. Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
* This branch was created from 52-add-score-to-delta-object and thus
incorporates recent commits for issue #52.
* Scoring was previously determined in 'DeltaCode.determine_delta()',
'DeltaCode.update_deltas()' and 'Delta._license_diff()'.
* Refactored tests, added five new tests.
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
* Convert DeltaCode.deltas from OrderedDict to list.
* Sort list by Delta.score, high > low.
* Refactor other methods etc. as necessary.
* Delete DeltaCode.to_dict() method.
* Fix 58 failing tests.
* Note that in test_DeltaCode_get_stats_original_path_openssl(), for
some reason 'modified' is now 290, not 291.
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
steven-esser
approved these changes
Feb 14, 2018
This was referenced Feb 15, 2018
arnav-mandal1234
pushed a commit
to arnav-mandal1234/deltacode
that referenced
this pull request
Mar 16, 2023
Properly check for existance of thirdparty dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.