Convert to json2csv script #75 - #94
Merged
Merged
Conversation
* We'll then move json2csv.py and related tests and test data into the
existing src/ and tests/ structure so that we can import json2csv
and call its methods from cli.py.
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
* Added json2csv.py and related tests and test files. * Deleted cli.write_csv() and related call, tests and files. * Revised help. Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
steven-esser
suggested changes
Apr 3, 2018
steven-esser
left a comment
Contributor
There was a problem hiding this comment.
See comment on test_json2csv.py
We just need the nexB + apache 2.0 notice text at the top of the file then this is good to go.
| @@ -0,0 +1,279 @@ | |||
| from __future__ import print_function | |||
Contributor
There was a problem hiding this comment.
We should add the nexB notice and apache 2.0 header here, like we did in the above file
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
steven-esser
approved these changes
Apr 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.