Call paths.safe_path using preserve_spaces argument - #28
Merged
Conversation
* Update expected test results Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
preserve_spaces_in_filenames_for_extracted_files
branch
from
July 23, 2021 20:54
ce5ee74 to
da7496d
Compare
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
preserve_spaces_in_filenames_for_extracted_files
branch
from
July 23, 2021 21:06
da7496d to
d753aa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We modified
commoncode.paths.portable_filenamein aboutcode-org/commoncode#26 to have the option to not replace spaces and we updatedextractcodeto use this new feature to address #27.Signed-off-by: Jono Yang jyang@nexb.com