Skip to content

Fix duplicated github and gitlab TLD’s - #21

Merged
JonoYang merged 2 commits into
aboutcode-org:mainfrom
nedix:fix/issue-20-duplicated-tld
Aug 9, 2025
Merged

Fix duplicated github and gitlab TLD’s#21
JonoYang merged 2 commits into
aboutcode-org:mainfrom
nedix:fix/issue-20-duplicated-tld

Conversation

@nedix

@nedix nedix commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

Please peer review.

Fixes #20
Fixes aboutcode-org/scancode.io#1753

@nedix

nedix commented Jul 25, 2025

Copy link
Copy Markdown
Contributor Author

I don't understand why not all checks pass successfully. Can you advise please @pombredanne ?

@nedix

nedix commented Aug 6, 2025

Copy link
Copy Markdown
Contributor Author

@JonoYang Can you help fix the workflow checks?

@JonoYang

JonoYang commented Aug 9, 2025

Copy link
Copy Markdown
Member

@nedix Thanks for the PR! I've updated the project config files in #22 so we can use the latest ubuntu runners. You can try pulling in the changes and see if that helps

nedix added 2 commits August 9, 2025 17:34
Signed-off-by: Hans van der Woude <2658411+nedix@users.noreply.github.com>
Signed-off-by: Hans van der Woude <2658411+nedix@users.noreply.github.com>
@nedix

nedix commented Aug 9, 2025

Copy link
Copy Markdown
Contributor Author

@JonoYang All checks pass. This PR is awaiting approval.

@JonoYang
JonoYang merged commit fbf12e4 into aboutcode-org:main Aug 9, 2025
6 checks passed
@JonoYang

JonoYang commented Aug 9, 2025

Copy link
Copy Markdown
Member

@nedix Thanks, merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicated TLD returned by utils.get_urls (eg: "github.com.com") Repetition of homepage TLD (eg: github.com.com)

2 participants