Skip to content

Travis CI: Explain why we use "cpp" instead of "python" - #5

Merged
pombredanne merged 2 commits into
aboutcode-org:masterfrom
sschuberth:patch-1
Feb 10, 2017
Merged

Travis CI: Explain why we use "cpp" instead of "python"#5
pombredanne merged 2 commits into
aboutcode-org:masterfrom
sschuberth:patch-1

Conversation

@sschuberth

@sschuberth sschuberth commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

Because that deserves some explanation.

@pombredanne

Copy link
Copy Markdown
Member

@sschuberth I reckon it looks odd. But this is NOT a bug. We have to use the cpp config because we are using the multi-os (linux + mac) travis support (which is enabled only by special request) per https://github.com/nexB/license-expression/blob/025fee38d84aa19f32050c0802eb27e0f0852bc7/.travis.yml#L3 and this has to be used then. So if you do not do that, whatever the internal reasons may be at Travis the mac build will not work at all .... which is what you see just here in the build results

@sschuberth

Copy link
Copy Markdown
Contributor Author

@pombredanne I was assuming something like that after seeing the OSX builds fail. I'll change this PR to add a comment to .travis.yml instead.

@sschuberth sschuberth changed the title Travis CI: Set the language to Python Travis CI: Explain why we use "cpp" instead of "python" Feb 9, 2017
@sschuberth

Copy link
Copy Markdown
Contributor Author

@pombredanne Does the wording of the comment nail it?

Comment thread .travis.yml Outdated
@@ -1,3 +1,5 @@
# This deliverately is not "python" as a work-around to support

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you meant deliberately?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Thanks for fixing it already.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
pombredanne merged commit f0d504f into aboutcode-org:master Feb 10, 2017
@pombredanne

Copy link
Copy Markdown
Member

Thanks! I tried the "commit in your branch feature" and it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants