Skip to content

Add ignore_errors flag and update PythonUpdateProvider - #157

Closed
qequ wants to merge 14 commits into
aboutcode-org:mainfrom
qequ:feature-ignore-errors-mode
Closed

qequ wants to merge 14 commits into
aboutcode-org:mainfrom
qequ:feature-ignore-errors-mode

Conversation

@qequ

@qequ qequ commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

Add a flag to continue operating when non existang packages happen

Fixes #141

@TG1999 TG1999 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qequ thanks++, please add tests for the changes you have added

@qequ
qequ force-pushed the feature-ignore-errors-mode branch from c657860 to b4f4113 Compare November 7, 2023 04:07
@qequ

qequ commented Nov 7, 2023

Copy link
Copy Markdown
Contributor Author

@TG1999 Added tests

@TG1999

TG1999 commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

@qequ DCO is failing, please add your sign-off

Signed-off-by: Alvaro Frias Garay <alvaro.frias@eclypsium.com>
Signed-off-by: Alvaro Frias <alvarofriasgaray@gmail>
Signed-off-by: Alvaro Frias <alvarofriasgaray@gmail.com>
@qequ
qequ force-pushed the feature-ignore-errors-mode branch from b4f4113 to 3e8c514 Compare November 10, 2023 14:52
qequ added 3 commits November 10, 2023 11:55
Signed-off-by: Alvaro Frias <alvarofriasgaray@gmail.com>
Signed-off-by: Alvaro Frias <alvarofriasgaray@gmail.com>
Signed-off-by: Alvaro Frias <alvarofriasgaray@gmail.com>
@qequ
qequ force-pushed the feature-ignore-errors-mode branch from 3e8c514 to 717b9c6 Compare November 10, 2023 14:56
@qequ

qequ commented Nov 10, 2023

Copy link
Copy Markdown
Contributor Author

@TG1999 signed 👍

@TG1999

TG1999 commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

@qequ the tests for CI doesn't seem to work can you please check once ?

@qequ

qequ commented Nov 16, 2023

Copy link
Copy Markdown
Contributor Author

@TG1999 I ran the tests with pytest -vvs ont he main branch and the branch of this feature and in both the same errors are happening

logs of the errors in both branches

this branch tests

============================================================================================= short test summary info =============================================================================================
FAILED tests/test_cli.py::test_cli_with_single_index_url_except_pypi_simple - assert {'files': [],\n 'headers': {'errors': [],\n             'notice': 'Dependency tree generated with python-inspector.\n'\n   ...
FAILED tests/test_cli.py::test_cli_with_azure_devops_with_python_310 - assert {'files': [{'package_data': [{'api_data_url': None,\n                              'bug_tracking_url': None,\n                    ...
FAILED tests/test_cli.py::test_cli_with_azure_devops_with_python_38 - assert {'files': [{'package_data': [{'api_data_url': None,\n                              'bug_tracking_url': None,\n                     ...
FAILED tests/test_cli.py::test_cli_with_insecure_option_testpkh - assert {'files': [{'package_data': [{'api_data_url': 'https://pypi.org/pypi/testpkh/0.0.1/json',\n                              'bug_tracking_...
FAILED tests/test_codestyle.py::BaseTests::test_codestyle - Exception: ('Code style check failed!', b'-> Run pycodestyle (PEP8) validation\n')
FAILED tests/test_resolution.py::test_get_resolved_dependencies_for_version_containing_local_version_identifier - AssertionError: assert ['pkg:pypi/filelock@3.9.0',\n 'pkg:pypi/jinja2@3.1.2',\n 'pkg:pypi/mark...
============================================================================ 6 failed, 161 passed, 1424 warnings in 292.36s (0:04:52) =============================================================================

main branch tests

============================================================================================= short test summary info =============================================================================================
FAILED tests/test_cli.py::test_cli_with_single_index_url_except_pypi_simple - assert {'files': [],\n 'headers': {'errors': [],\n             'notice': 'Dependency tree generated with python-inspector.\n'\n   ...
FAILED tests/test_cli.py::test_cli_with_azure_devops_with_python_310 - assert {'files': [{'package_data': [{'api_data_url': None,\n                              'bug_tracking_url': None,\n                    ...
FAILED tests/test_cli.py::test_cli_with_azure_devops_with_python_38 - assert {'files': [{'package_data': [{'api_data_url': None,\n                              'bug_tracking_url': None,\n                     ...
FAILED tests/test_cli.py::test_cli_with_insecure_option_testpkh - assert {'files': [{'package_data': [{'api_data_url': 'https://pypi.org/pypi/testpkh/0.0.1/json',\n                              'bug_tracking_...
FAILED tests/test_codestyle.py::BaseTests::test_codestyle - Exception: ('Code style check failed!', b'-> Run pycodestyle (PEP8) validation\n')
FAILED tests/test_resolution.py::test_get_resolved_dependencies_for_version_containing_local_version_identifier - AssertionError: assert ['pkg:pypi/filelock@3.9.0',\n 'pkg:pypi/jinja2@3.1.2',\n 'pkg:pypi/mark...
============================================================================ 6 failed, 160 passed, 1423 warnings in 158.86s (0:02:38) =============================================================================

it seems the main branch makes the tests fail. can you confirm this?

qequ added 2 commits November 16, 2023 19:05
Signed-off-by: Alvaro Frias Garay <alvarofriasgaray@gmail.com>
Signed-off-by: Alvaro Frias Garay <alvarofriasgaray@gmail.com>
@qequ

qequ commented Nov 16, 2023

Copy link
Copy Markdown
Contributor Author

@TG1999 I have updated the expected outputs in tests. Most of failures were due to expected outputs being outdated for online tests like flask

@qequ
qequ requested a review from TG1999 November 17, 2023 13:08
@TG1999

TG1999 commented Nov 20, 2023

Copy link
Copy Markdown
Contributor

@qequ please rebase and resolve conflicts

qequ and others added 8 commits November 20, 2023 12:22
Signed-off-by: Alvaro Frias Garay <alvaro.frias@eclypsium.com>
Signed-off-by: Alvaro Frias <alvarofriasgaray@gmail>
Signed-off-by: Alvaro Frias <alvarofriasgaray@gmail.com>
Signed-off-by: Alvaro Frias <alvarofriasgaray@gmail.com>
Signed-off-by: Alvaro Frias <alvarofriasgaray@gmail.com>
Signed-off-by: Alvaro Frias <alvarofriasgaray@gmail.com>
Signed-off-by: Alvaro Frias Garay <alvarofriasgaray@gmail.com>
…nspector into feature-ignore-errors-mode

Signed-off-by: Alvaro Frias Garay <alvarofriasgaray@gmail.com>
…nspector into feature-ignore-errors-mode

Signed-off-by: Alvaro Frias Garay <alvarofriasgaray@gmail.com>
@qequ qequ closed this Nov 20, 2023
@qequ qequ reopened this Nov 20, 2023
@qequ qequ closed this Nov 20, 2023
@qequ qequ reopened this Nov 20, 2023
@qequ qequ closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graceful handling of non-existent packages

2 participants