Skip to content

Add --max-rounds param in CLI - #30

Merged
TG1999 merged 4 commits into
mainfrom
max_rounds
Jun 29, 2022
Merged

Add --max-rounds param in CLI#30
TG1999 merged 4 commits into
mainfrom
max_rounds

Conversation

@TG1999

@TG1999 TG1999 commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

Sometimes resolution may feel coz the resolution is too much nested or deep or circular, adding a param for max rounds so end user can increase max-rounds if it fails for the default max rounds i.e 100

TG1999 added 2 commits June 28, 2022 21:30
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Reference: https://pypi.org/project/importlib-metadata/#history
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
TG1999 requested review from JonoYang and pombredanne June 28, 2022 16:03
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

@JonoYang JonoYang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
TG1999 merged commit 6a40806 into main Jun 29, 2022
@TG1999
TG1999 deleted the max_rounds branch July 11, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants