Skip to content

Clean cli output - #43

Merged
TG1999 merged 2 commits into
mainfrom
clean_cli_output
Jul 29, 2022
Merged

Clean cli output#43
TG1999 merged 2 commits into
mainfrom
clean_cli_output

Conversation

@TG1999

@TG1999 TG1999 commented Jul 22, 2022

Copy link
Copy Markdown
Contributor

closes #40

@TG1999
TG1999 force-pushed the clean_cli_output branch 3 times, most recently from 91a9d22 to f97a90b Compare July 22, 2022 11:19
@TG1999
TG1999 requested a review from pombredanne July 22, 2022 11:23

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor nit... but there seems to be changes already covered in #42 ? Are these the same?

Comment thread src/python_inspector/resolution.py
Comment thread src/python_inspector/resolution.py Outdated
@TG1999

TG1999 commented Jul 27, 2022

Copy link
Copy Markdown
Contributor Author

I have cut a branch from #42 here, will rebase once #42 gets merged

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
TG1999 force-pushed the clean_cli_output branch from f97a90b to f05ad97 Compare July 29, 2022 12:42
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
TG1999 force-pushed the clean_cli_output branch from f05ad97 to be60160 Compare July 29, 2022 12:46
@TG1999

TG1999 commented Jul 29, 2022

Copy link
Copy Markdown
Contributor Author

Thanks! merging

@TG1999
TG1999 merged commit 93df5a6 into main Jul 29, 2022
@pombredanne
pombredanne deleted the clean_cli_output branch July 29, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not log anything by default

2 participants