Support rust binary parsing - #1
Merged
Merged
Conversation
AyanSinhaMahapatra
force-pushed
the
support-rust-binary
branch
from
December 23, 2024 09:51
7727573 to
d571698
Compare
Support parsing rust binaries and getting: 1. Symbols 2. Packages and Dependencies Reference: aboutcode-org/scancode.io#1435 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
support-rust-binary
branch
from
December 23, 2024 10:07
97ab2d1 to
2d05cfd
Compare
pombredanne
approved these changes
Dec 23, 2024
pombredanne
left a comment
Member
There was a problem hiding this comment.
Looking fine overall, see some minor nits inline for your review.
Please merge as you like.
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Member
Author
|
All green, thanks @pombredanne for the review! Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: aboutcode-org/scancode.io#1435
Support parsing rust binaries and getting: