Add support for PyYAML v5 #1

[pombredanne]

• This is a fix for saneyaml requires too precise version of PyYAML, can't be installed easily with pip on real systems #1 to support both PyYAML 3.1x and the newer PyYAML 5.1.x
  Several subtle changes had been introduced and this resolves them all.

• The PyYAML version constraint has been entirely removed from setup.py

• CI testing has been enabled on Appveyor/WIndows an Travis/Linux

Reported-by: Dan Kegel dank@kegel.com
Signed-off-by: Philippe Ombredanne pombredanne@nexb.com

[pombredanne]

@dankegel ping. Do you mind testing this in your config?

[pombredanne]

@dankegel I also tagged and pushed a release 0.4 https://pypi.org/project/saneyaml/0.4/

[dankegel]

I installed https://launchpad.net/~dank/+archive/ubuntu/python-fixes to work around the nastier problems in the system pip + python ecosystem, then ran 'pip install scancode-toolkit; scancode --version' across my fleet.

I can still see the original problem like this:

$ rm -rf ~/.local
$ pip install scancode-toolkit
$ scancode --version
ScanCode version 3.0.2
$ pip list | grep -i pyyaml
PyYAML (3.13)
$ pip install PyYaml==5.1
$ scancode --version
pluggy.manager.PluginValidationError: Plugin 'json-pp' could not be loaded: (PyYAML 5.1 (/home/buildbot/.local/lib/python2.7/site-packages), Requirement.parse('PyYAML<=3.13,>=3.11'))!

I'm a bit dense, though, since that's probably expected until scancode drops its own strict
PyYAML dependency...

Incidentally, I learned that pip 8.1 at least seems to lie when you ask it to uninstall things; it leaves
behind foo-x.y.dist-info directories that confuse things. So when troubleshooting, rm -rf ~/.local (or, more sanely, mv ~/.local ~/.local.bad) is crucial for figuring out wtf is going on.

[jelmer]

Any news on this?

[pombredanne]

@jelmer let me merge this and push a few new updates. Thanks for the reminder!