Skip to content

Fix renamed CommandLineOption - #10

Merged
pombredanne merged 1 commit into
aboutcode-org:mainfrom
larsla:fix-cmdopt
Aug 13, 2021
Merged

Fix renamed CommandLineOption#10
pombredanne merged 1 commit into
aboutcode-org:mainfrom
larsla:fix-cmdopt

Conversation

@larsla

@larsla larsla commented May 6, 2021

Copy link
Copy Markdown
Contributor

This PR fixes the plugins after CommandLineOption was renamed to PluggableCommandLineOption in the scancode package.

@pombredanne

Copy link
Copy Markdown
Member

@larsla Thank you and sorry for the late review!
Do you mind to add a DCO signoff to your commits or at least as a comment in this PR before I can merge?

@pombredanne

Copy link
Copy Markdown
Member

@larsla gentle ping: do you mind to add a DCO signoff, at least as a message in this PR?
This looks like here at the bottom: https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html
Mine would be: Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Thanks!

@pombredanne

Copy link
Copy Markdown
Member

gentle ping

Signed-off-by: Lars Larsson <github@lars.dev>
@larsla

larsla commented Aug 10, 2021

Copy link
Copy Markdown
Contributor Author

@pombredanne Sorry, these notifications got lost in everything else.
How does it look now?

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++
Thanks!

@pombredanne
pombredanne merged commit f36c8d3 into aboutcode-org:main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants