Add new builtin plugin for msitools binaries - #12
Merged
Conversation
Signed-off-by: Jono Yang <jyang@nexb.com>
* Remove dist and build directories Signed-off-by: Jono Yang <jyang@nexb.com>
pombredanne
reviewed
Jun 19, 2021
pombredanne
requested changes
Jun 19, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks . See a few comments inline
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
packagedcode-msitools
branch
from
June 21, 2021 06:03
d347bab to
8139daf
Compare
Member
Author
|
@pombredanne I've addressed your comments. Quick question about license: I noticed that |
pombredanne
approved these changes
Jul 6, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
See a few nit inline. LGTM otherwise
* Update build scripts
* Add license files and update license expression for the plugin
Signed-off-by: Jono Yang <jyang@nexb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new builtin plugin that compiles msitools and packs the binaries into a locationprovider plugin. This is used for aboutcode-org/scancode-toolkit#2559 and related to aboutcode-org/scancode-toolkit#2565