bsd-simplified license text without disclaimer

[AyanSinhaMahapatra]

We have a bsd text in several debian copyright files tagged BSD-2-clause which is just first two clauses of BSD-3-clause , so basically with a mention of disclaimer without the disclaimer itself. This isn't getting detected by scancode exactly, so a new rule (or maybe license?) needs to be added but I'm not sure of the license-expression, since it's different from bsd-new or bsd-simplified or bsd-no-disclaimer, more like -> bsd-simplified-no-disclaimer-text

 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions
 are met:
 1. Redistributions of source code must retain the above copyright
    notice, this list of conditions and the following disclaimer.
 2. Redistributions in binary form must reproduce the above copyright
    notice, this list of conditions and the following disclaimer in the
    documentation and/or other materials provided with the distribution.

Example: https://github.com/nexB/scancode-toolkit/blob/develop/tests/packagedcode/data/debian/copyright/debian-slim-2021-04-07/usr/share/doc/libblkid1/copyright#L402

Matched License with diagnostics:

"licenses": [
        {
          "key": "bsd-no-disclaimer",
          "score": 84.38,
          "name": "BSD-2-Clause without Warranty Disclaimer",
          "short_name": "BSD-2-Clause no disclaimer",
          "category": "Permissive",
          "is_exception": false,
          "owner": "Unspecified",
          "homepage_url": null,
          "text_url": "",
          "reference_url": "https://scancode-licensedb.aboutcode.org/bsd-no-disclaimer",
          "scancode_text_url": "https://github.com/nexB/scancode-toolkit/tree/develop/src/licensedcode/data/licenses/bsd-no-disclaimer.LICENSE",
          "scancode_data_url": "https://github.com/nexB/scancode-toolkit/tree/develop/src/licensedcode/data/licenses/bsd-no-disclaimer.yml",
          "spdx_license_key": "LicenseRef-scancode-bsd-no-disclaimer",
          "spdx_url": "https://github.com/nexB/scancode-toolkit/tree/develop/src/licensedcode/data/licenses/bsd-no-disclaimer.LICENSE",
          "start_line": 1,
          "end_line": 8,
          "matched_rule": {
            "identifier": "bsd-no-disclaimer.LICENSE",
            "license_expression": "bsd-no-disclaimer",
            "licenses": [
              "bsd-no-disclaimer"
            ],
            "is_license_text": true,
            "is_license_notice": false,
            "is_license_reference": false,
            "is_license_tag": false,
            "is_license_intro": false,
            "matcher": "3-seq",
            "rule_length": 64,
            "matched_length": 54,
            "match_coverage": 84.38,
            "rule_relevance": 100
          },
          "matched_text": "Redistribution and use in source and binary forms, with or without\n modification, are permitted provided that the following conditions\n are met:\n 1. Redistributions of source code must retain the above copyright\n    notice, [this] [list] [of] [conditions] [and] [the] [following] [disclaimer].\n 2. Redistributions in binary form must reproduce the above copyright\n    notice, [this] [list] [of] [conditions] [and] [the] [following] [disclaimer] in the\n    documentation and/or other materials provided with the distribution."
        }
      ],

Note that the disclaimer is present elsewhere in the file in the Bsd-3-Clause License Paragraph.

Should this just be a Rule or a new License? What should the license-expression be ?
@DennisClark @pombredanne

[pombredanne]

@AyanSinhaMahapatra great find!

1. you should report a bug @ Debian and link it here
2. we do not need a new license IMHO as this is a Debian packager mistake
3. I would create two rules with the same body of text and one prefixed with License: BSD-2-clause and make them 99% relevance, and 100% minimum coverage with a note explaining where it is found

[AyanSinhaMahapatra]

Bug reported at debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990067

[DennisClark]

@AyanSinhaMahapatra the license text you provided in this issue was created as LicenseRef-scancode-bsd-no-disclaimer-unmodified by @pombredanne in DejaCode on Jul 11, 2019, 1:28 PM PDT and modified on Jun 16, 2022, 7:19 AM PDT and it is in the LicenseDB at https://scancode-licensedb.aboutcode.org/index.html?search=LicenseRef-scancode-bsd-no-disclaimer-unmodified

Testing now on your example file.

[DennisClark]

@AyanSinhaMahapatra The license LicenseRef-scancode-bsd-no-disclaimer-unmodified which is an exact match with the text in https://github.com/nexB/scancode-toolkit/blob/develop/tests/packagedcode/data/debian/copyright/debian-slim-2021-04-07/usr/share/doc/libblkid1/copyright#L402 is not being detected. Please update the Rules to do that, thanks.

debian-copyright.txt
debian-copyright.txt-results.json