MediaTek proprietary license (4)

[armijnhemel]

Description

Similar to, yet different from the first part of proprietary-license_663.RULE and #3322 :

https://github.com/Mediatek-Cloud/mcs.c/blob/master/reference/iot_sdk_demo/cli_readme.txt

[armijnhemel]

There is also an expanded version:

https://github.com/mangOH/MT7697_WiFi_BT_fw/blob/master/inc/task_def.h

[pombredanne]

@armijnhemel Thanks for all these reports ...

• Do you think these Mediatek licenses warrant having one or more license key? like was done here https://github.com/nexB/scancode-toolkit/blob/9f91bf515712078ab00466c9ee66ff29f0e1cdd2/src/licensedcode/data/licenses/ralink-firmware.LICENSE

• Or they are rather just rules that will be detected as generic "proprietary-license", like we have with https://github.com/nexB/scancode-toolkit/blob/develop/src/licensedcode/data/rules/proprietary-license_663.RULE that matches the report in https://github.com/BPI-SINOVOIP/BPI-R2-bsp/blob/master/vendor/mediatek/connectivity/tools/src/wmt_loopback.c

These issues are for reference:

• Mediatek MediaTek proprietary license (5) #3327 MediaTek firmware license #3326 MediaTek proprietary license (4) #3325 MediaTek proprietary license (3) #3324 MediaTek proprietary license (2) #3323 MediaTek proprietary license #3322
• And unrelated MStar MStar proprietary license (2) #3321 MStar proprietary license #3320

[armijnhemel]

@armijnhemel Thanks for all these reports ...

* Do you think these Mediatek licenses warrant having one or more license key?  like was done here https://github.com/nexB/scancode-toolkit/blob/9f91bf515712078ab00466c9ee66ff29f0e1cdd2/src/licensedcode/data/licenses/ralink-firmware.LICENSE

* Or they are rather just rules that will be detected as generic "proprietary-license", like we have with https://github.com/nexB/scancode-toolkit/blob/develop/src/licensedcode/data/rules/proprietary-license_663.RULE that matches the report in https://github.com/BPI-SINOVOIP/BPI-R2-bsp/blob/master/vendor/mediatek/connectivity/tools/src/wmt_loopback.c

These issues are for reference:

* Mediatek [MediaTek proprietary license (5) #3327](https://github.com/nexB/scancode-toolkit/issues/3327) [MediaTek firmware license #3326](https://github.com/nexB/scancode-toolkit/issues/3326) [MediaTek proprietary license (4) #3325](https://github.com/nexB/scancode-toolkit/issues/3325) [MediaTek proprietary license (3) #3324](https://github.com/nexB/scancode-toolkit/issues/3324) [MediaTek proprietary license (2) #3323](https://github.com/nexB/scancode-toolkit/issues/3323) [MediaTek proprietary license #3322](https://github.com/nexB/scancode-toolkit/issues/3322)

* And unrelated MStar [MStar proprietary license (2) #3321](https://github.com/nexB/scancode-toolkit/issues/3321) [MStar proprietary license #3320](https://github.com/nexB/scancode-toolkit/issues/3320)

As long as it is easy for me to spot that it is from MediaTek and/or MStar I don't care that much. Please also see #3319

[armijnhemel]

How has this been fixed by #3234 ?

[armijnhemel]

So it seems that #3234 referenced the wrong issue, so now this one has been closed instead of the real issue. Please reopen.

[pombredanne]

@armijnhemel sorry for the churn. GitHub habit to close issues is sometimes helpful, but often a PITA.

[DennisClark]

It seems to me that the text at https://github.com/Mediatek-Cloud/mcs.c/blob/master/reference/iot_sdk_demo/cli_readme.txt is mainly a notice that "you must have a license" and not really a license itself. Not sure what action to take next.