Ensure viskores license is detected correctly with extra rules

[pombredanne]

Reported by @opoplawski and discussed with @richardfontana on the Fedora legal mailing list:
https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/NEF754GWMNKY2YJ4CSWQG4472IHPPGX7/

This is a plain BSD-3-Cluase license that has been given another name by @vicentebolea

See for notices that may need some love to be detected correctly

• https://github.com/Viskores/viskores/blob/537a4a91a38fc6e1fa783369f458fcf6bbc1e8a9/CMake/ViskoresDeviceAdapters.cmake#L1

##  The contents of this file are covered by the Viskores license. See
##  LICENSE.txt for details.
##
##  By contributing to this file, all contributors agree to the Developer
##  Certificate of Origin Version 1.1 (DCO 1.1) as stated in DCO.txt.

The license text itself at https://raw.githubusercontent.com/Viskores/viskores/refs/heads/main/LICENSE.txt is detected correctly as a BSD-3-Clause by ScanCode, with one word (AUTHORS) not matched, so we could add one rule for that:

matched_text_diagnostics: |
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:

• Redistributions of source code must retain the above copyright
  notice, this list of conditions and the following disclaimer.

• Redistributions in binary form must reproduce the above copyright
  notice, this list of conditions and the following disclaimer in the
  documentation and/or other materials provided with the
  distribution.

• Neither the name of [Kitware] nor the names of any contributors may
  be used to endorse or promote products derived from this software
  without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE [AUTHORS] OR
CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

@alok1304 ... this could be a nice test case for your project.

[vicentebolea]

Thanks for pointing this out, let me know if you need any change from my side

[pombredanne]

@vicentebolea here are my recommendations:

1. use the common, de-facto standard BSD-3-Clause text as published a the OSI: https://opensource.org/license/BSD-3-Clause
2. streamline your license text for detection, stop naming this as "Viskores license"
3. adopt SPDX license identifiers in your notices (and if you like, you can go with the REUSE.software conventions)
4. remove as much boilerplate as possible for clarity

A minimal change would be something along the lines of this PR/suggestion:

• https://github.com/Viskores/viskores/pull/146/files

You have another possible issue with ECL graph licenses:

• New license request: ECL graph converter license #4509