Add new and improved license rules - #1337
Merged
Merged
Conversation
Here an x11-fsf was incorrectly returned. Reported-by: Dan Kegel @dankegel Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Refine and review remaining bare GPL rules Reported-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Codecov Report
@@ Coverage Diff @@
## develop #1337 +/- ##
===========================================
+ Coverage 84.17% 84.21% +0.03%
===========================================
Files 117 117
Lines 13154 13154
===========================================
+ Hits 11073 11078 +5
+ Misses 2081 2076 -5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1337 +/- ##
===========================================
- Coverage 84.17% 84.17% -0.01%
===========================================
Files 117 117
Lines 13154 13175 +21
===========================================
+ Hits 11073 11090 +17
- Misses 2081 2085 +4
Continue to review full report at Codecov.
|
Reported-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Otherwise this was detected by gpl-2.0-_300.RULE as a gpl-2.0 license. Reported-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reported-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Otherwise this was detected as a gpl-2.0 license. Reported-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This is a bona-fide notice Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Otherwise this was detected by gpl-2.0-plus_220.RULE as a gpl-2.0-plus license. Reported-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reported-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Otherwise this was detected as a gpl-2.0 license. Reported-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Otherwise this was detected as a gpl-2.0 license. Reported-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
These are rare yet seen in some popular NuGet packages Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Several are not detected. Added some new licenses too. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This adds a new rule, but the expectations are not yet correct and will evolve when license detection is enabled in Maven tests Reported-by: Li Ha @linexb Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
- Add new rule attribute: only_known_words. with this attribute set to yes, a rule can be matched only if no unknown words are found in the matched range. This is useful for some small rule that could otherwise be matched as false positives with some unknown (and therefore unmatched) tokens in their range - Add new qmagnitude, qrange and qdensity methods to LicenseMatch that are used in score computation and filtering as well as to determine if there are unknown tokens within a matched range (e.g. on the query side hence the "q" prefix) - Add new match filtering function "filter_if_only_known_words_rule" that use the new rule flag and related methods. - cleanup logging code in refine_matches() function Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Add referenced_filenames and relevance attributes as needed Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Most rules are fixing detection issues found when scanning the Linux Kernel Reported-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This adds several misc detection rules. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This are different enough to warrant an addition Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Treat all media and .ppm and .pgm in particualr as not containing text (and therefore not scanned for copyrights and licenses) Reported-by: Armijn Hemel @armijnhemel Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Add new rules to avoid confusion with an Apache notice Reported-by: Armijn Hemel @armijnhemel Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reported-by: Armijn Hemel @armijnhemel Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Fix tests Reported-by: Armijn Hemel @armijnhemel Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
http://www.w3.org/XML/1998/namespace and http://www.w3.org/2000/xmlns/ Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a set of new licenses and license detection rules
And in particular a fix for #1336 as reported by @dankegel
Also has fixes for #1344 #1345 #1346 #1347 #1348 #1335 several of which have beeen reported by @armijnhemel and several Linux-related issues reported privately by kernel maintainers.
Signed-off-by: Philippe Ombredanne pombredanne@nexb.com