Add a license for the PSK contributions to OpenSSL - #1341
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1341 +/- ##
============================================
- Coverage 84.19% 69.82% -14.37%
============================================
Files 117 117
Lines 13154 13154
============================================
- Hits 11075 9185 -1890
- Misses 2079 3969 +1890
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1341 +/- ##
==========================================
+ Coverage 84.19% 84.2% +<.01%
==========================================
Files 117 117
Lines 13154 13154
==========================================
+ Hits 11075 11076 +1
+ Misses 2079 2078 -1
Continue to review full report at Codecov.
|
pombredanne
left a comment
There was a problem hiding this comment.
@fviernau Thank you ++
I wonder if this should not be treated as an exception? the text explicitly mentions ... and is licensed pursuant to the OpenSSL open source license. so the core licensing terms would be these of the OpenSSL license ... and then these extra patent-related terms are some exception/supplemental terms to the base OpenSSL.
In this case the text would be only this for the exception .LICENSE file:
No patent licenses or other rights except those expressly stated in
the OpenSSL open source license shall be deemed granted or received
expressly, by implication, estoppel, or otherwise.
No assurances are provided by Nokia that the Contribution does not
infringe the patent or other intellectual property rights of any third
party or that the license provides you with all the necessary rights
to make use of the Contribution.
THE SOFTWARE IS PROVIDED "AS IS" WITHOUT WARRANTY OF ANY KIND. IN
ADDITION TO THE DISCLAIMERS INCLUDED IN THE LICENSE, NOKIA
SPECIFICALLY DISCLAIMS ANY LIABILITY FOR CLAIMS BROUGHT BY YOU OR ANY
OTHER ENTITY BASED ON INFRINGEMENT OF INTELLECTUAL PROPERTY RIGHTS OR
OTHERWISE.
and there could be a rule that would return openssl-ssleay WITH openssl-nokia-psk-contribution for the combo of
The portions of the attached software ("Contribution") is developed by
Nokia Corporation and is licensed pursuant to the OpenSSL open source
license.
I'd like to get @DennisClark opinion on this: new license or new exception?
Yet another possibility would be to treat this disclaimer text as a rule for the generic patent-disclaimer https://github.com/nexB/scancode-toolkit/blob/develop/src/licensedcode/data/licenses/patent-disclaimer.yml
instead.
| short_name: OpenSSL Nokia PSK Contribution | ||
| category: Permissive | ||
| owner: Nokia | ||
| spdx_license_key: LicenseRef-OpenSSL-Nokia-PSK-Contribution |
There was a problem hiding this comment.
For now the approach has been not to put any LicenseRef for the license that are not known in the SPDX license list. There is a pending ticket #1328 by @sschuberth to review this approach and possibly assign always a LicenseRef (and there is also #532).
There was a problem hiding this comment.
Thanks! Removed the LicenseRef and updated the PR.
It seems I looked at the only .yml underneath licenses containing such LicenseRef, e.g. ./src/licensedcode/data/licenses/here-proprietary.yml. Out-of-scope here: should the LicenseRef be removed from that file?
Add the proprietary Nokia license (text) used for the `Pre-Shared Key` contributions to OpenSSL by Nokia, see openssl/openssl@ddac1974 Signed-off-by: Frank Viernau <frank.viernau@here.com>
|
A few comments:
|
|
@DennisClark any update? |
|
new license exception |
|
public access to the new license exception is at https://enterprise.dejacode.com/licenses/public/openssl-nokia-psk-contribution/ |
|
@pombredanne, as @fviernau is currently on vacation feel free to either do any still required chnages yourself, or tell me about it. |
|
@sschuberth we are good and I will merge and possibly update afterwards based on @DennisClark feedback |
In particular, this fixes the swapped bsl-1.0 / bsl-1.1 licenses [1] and adds the openssl-nokia-psk-contribution license (exception) [2]. [1] aboutcode-org/scancode-toolkit#1338 [2] aboutcode-org/scancode-toolkit#1341 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
In particular, this fixes the swapped bsl-1.0 / bsl-1.1 licenses [1] and adds the openssl-nokia-psk-contribution license (exception) [2]. [1] aboutcode-org/scancode-toolkit#1338 [2] aboutcode-org/scancode-toolkit#1341 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
In particular, this fixes the swapped bsl-1.0 / bsl-1.1 licenses [1] and adds the openssl-nokia-psk-contribution license (exception) [2]. [1] aboutcode-org/scancode-toolkit#1338 [2] aboutcode-org/scancode-toolkit#1341 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Reported-by: Frank Viernau <frank.viernau@here.com> Reported-by: @DennisClark Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Add the proprietary Nokia license (text) used for the
Pre-Shared Keycontributions to OpenSSL by Nokia, see
openssl/openssl@ddac1974