Skip to content

Accept non-standard package data in CSV #1398 - #1415

Merged
pombredanne merged 2 commits into
developfrom
1398-json2csv
Mar 6, 2019
Merged

pombredanne merged 2 commits into
developfrom
1398-json2csv

Conversation

@pombredanne

Copy link
Copy Markdown
Member

Signed-off-by: Philippe Ombredanne pombredanne@nexb.com

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@codecov

codecov Bot commented Mar 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1415 into develop will decrease coverage by 6.47%.
The diff coverage is 29.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1415      +/-   ##
===========================================
- Coverage    83.73%   77.26%   -6.48%     
===========================================
  Files          119      119              
  Lines        13919    14249     +330     
===========================================
- Hits         11655    11009     -646     
- Misses        2264     3240     +976
Impacted Files Coverage Δ
src/formattedcode/output_csv.py 19.18% <28.57%> (-65.54%) ⬇️
src/packagedcode/models.py 92% <50%> (-0.27%) ⬇️
src/commoncode/urn.py 0% <0%> (-100%) ⬇️
src/commoncode/version.py 0% <0%> (-100%) ⬇️
src/summarycode/utils.py 32% <0%> (-68%) ⬇️
src/formattedcode/output_spdx.py 26.59% <0%> (-66.49%) ⬇️
src/typecode/entropy.py 32% <0%> (-64%) ⬇️
src/summarycode/summarizer.py 31.28% <0%> (-60.52%) ⬇️
src/summarycode/score.py 29.83% <0%> (-57.34%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45bbafd...0bf5033. Read the comment docs.

@pombredanne

Copy link
Copy Markdown
Member Author

All good... merging. @chinyeungli this is a fix for #1398

@pombredanne
pombredanne merged commit 887ae13 into develop Mar 6, 2019
@pombredanne
pombredanne deleted the 1398-json2csv branch March 6, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant