Load resource from disk before returning None in get_resource() - #1423
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1423 +/- ##
============================================
- Coverage 83.65% 22.74% -60.92%
============================================
Files 119 118 -1
Lines 13949 13740 -209
============================================
- Hits 11669 3125 -8544
- Misses 2280 10615 +8335
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1423 +/- ##
===========================================
+ Coverage 83.57% 83.66% +0.09%
===========================================
Files 119 119
Lines 14032 14032
===========================================
+ Hits 11727 11740 +13
+ Misses 2305 2292 -13
Continue to review full report at Codecov.
|
Signed-off-by: Jono Yang <jyang@nexb.com>
* There should be a Resource specific test also Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne
force-pushed
the
1362-resource-not-loaded-before-removal
branch
from
March 7, 2019 10:11
bc76e73 to
8fbede6
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appears to fix #1362, but I am unsure of how to trigger the issue on command to test for it.