Skip to content

Load resource from disk before returning None in get_resource() - #1423

Merged
pombredanne merged 4 commits into
developfrom
1362-resource-not-loaded-before-removal
Mar 7, 2019
Merged

pombredanne merged 4 commits into
developfrom
1362-resource-not-loaded-before-removal

Conversation

@JonoYang

@JonoYang JonoYang commented Mar 7, 2019

Copy link
Copy Markdown
Member

This appears to fix #1362, but I am unsure of how to trigger the issue on command to test for it.

@codecov

codecov Bot commented Mar 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1423 into develop will decrease coverage by 60.91%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #1423       +/-   ##
============================================
- Coverage    83.65%   22.74%   -60.92%     
============================================
  Files          119      118        -1     
  Lines        13949    13740      -209     
============================================
- Hits         11669     3125     -8544     
- Misses        2280    10615     +8335
Impacted Files Coverage Δ
src/scancode/resource.py 0% <0%> (-85.7%) ⬇️
src/summarycode/utils.py 0% <0%> (-100%) ⬇️
src/cluecode/copyrights_hint.py 0% <0%> (-100%) ⬇️
src/cluecode/plugin_copyright.py 0% <0%> (-100%) ⬇️
src/cluecode/plugin_email.py 0% <0%> (-100%) ⬇️
src/commoncode/urn.py 0% <0%> (-100%) ⬇️
src/plugincode/output_filter.py 0% <0%> (-100%) ⬇️
src/scancode/plugin_only_findings.py 0% <0%> (-100%) ⬇️
src/commoncode/version.py 0% <0%> (-100%) ⬇️
src/packagedcode/pyrpm/rpmdefs.py 0% <0%> (-100%) ⬇️
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 887ae13...bc76e73. Read the comment docs.

@codecov

codecov Bot commented Mar 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1423 into develop will increase coverage by 0.09%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1423      +/-   ##
===========================================
+ Coverage    83.57%   83.66%   +0.09%     
===========================================
  Files          119      119              
  Lines        14032    14032              
===========================================
+ Hits         11727    11740      +13     
+ Misses        2305     2292      -13
Impacted Files Coverage Δ
src/scancode/plugin_ignore.py 76.36% <ø> (ø) ⬆️
src/scancode/resource.py 85.98% <50%> (ø) ⬆️
src/scancode/cli.py 78.15% <0%> (+1.04%) ⬆️
src/commoncode/fileutils.py 82.5% <0%> (+1.32%) ⬆️
src/scancode/api.py 94.81% <0%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd57613...8fbede6. Read the comment docs.

JonoYang and others added 4 commits March 7, 2019 10:29
    * There should be a Resource specific test also

Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
pombredanne force-pushed the 1362-resource-not-loaded-before-removal branch from bc76e73 to 8fbede6 Compare March 7, 2019 10:11
@pombredanne

Copy link
Copy Markdown
Member

@JonoYang I rebased on develop and added a test for the Codebase only in 8fbede6
LGTM... merging!

@pombredanne
pombredanne merged commit 3e70c5b into develop Mar 7, 2019
@pombredanne
pombredanne deleted the 1362-resource-not-loaded-before-removal branch March 7, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--ignore plugin does not work on latest develop

2 participants