Improve declared_license storage #1403 - #1526
Merged
Merged
Conversation
added 3 commits
April 12, 2019 20:55
Signed-off-by: Li <li@nexb.com>
Signed-off-by: Li <li@nexb.com>
Signed-off-by: Li <li@nexb.com>
Codecov Report
@@ Coverage Diff @@
## develop #1526 +/- ##
===========================================
+ Coverage 84.35% 84.38% +0.02%
===========================================
Files 122 122
Lines 14349 14381 +32
===========================================
+ Hits 12104 12135 +31
- Misses 2245 2246 +1
Continue to review full report at Codecov.
|
pombredanne
reviewed
Apr 16, 2019
added 4 commits
April 16, 2019 19:22
Signed-off-by: Li <li@nexb.com>
Signed-off-by: Li <li@nexb.com>
Signed-off-by: Li <li@nexb.com>
Signed-off-by: Li <li@nexb.com>
Member
|
LGTM ! thanks and merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve storage of declared_license for FreeBSD & phpcomposer packages.
Now using correct data structures instead of plain string
Signed-off-by: Li li@nexb.com