Skip to content

Log package scan exceptions - #1540

Merged
pombredanne merged 1 commit into
developfrom
1533-log-package-scan-exceptions
Apr 22, 2019
Merged

pombredanne merged 1 commit into
developfrom
1533-log-package-scan-exceptions

Conversation

@JonoYang

Copy link
Copy Markdown
Member

I've made a small change in get_package_info to log exceptions when attempting to parse manifest files if the TRACE flag is active.

Signed-off-by: Jono Yang <jyang@nexb.com>
@codecov

codecov Bot commented Apr 19, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1540 into develop will decrease coverage by 0.02%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1540      +/-   ##
===========================================
- Coverage    84.35%   84.32%   -0.03%     
===========================================
  Files          122      122              
  Lines        14349    14358       +9     
===========================================
+ Hits         12104    12108       +4     
- Misses        2245     2250       +5
Impacted Files Coverage Δ
src/scancode/api.py 95.1% <40%> (-3.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6544198...e50765c. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Apr 19, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1540 into develop will decrease coverage by 0.02%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1540      +/-   ##
===========================================
- Coverage    84.35%   84.32%   -0.03%     
===========================================
  Files          122      122              
  Lines        14349    14358       +9     
===========================================
+ Hits         12104    12108       +4     
- Misses        2245     2250       +5
Impacted Files Coverage Δ
src/scancode/api.py 95.1% <40%> (-3.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6544198...e50765c. Read the comment docs.

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. That simple, neat and useful. Merging.

@pombredanne
pombredanne merged commit 153a99b into develop Apr 22, 2019
@pombredanne
pombredanne deleted the 1533-log-package-scan-exceptions branch April 22, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants