Load multiple scans #1439 - #1558
Merged
Merged
Conversation
* This does not work yet Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
* Update comments Signed-off-by: Jono Yang <jyang@nexb.com>
* Add test that creates a VirtualCodebase from multiple scans
* Check to see if headers exist before attempting to get them when loading scan_data
* Raise Exception when importing a scan with no files
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Codecov Report
@@ Coverage Diff @@
## develop #1558 +/- ##
==========================================
+ Coverage 84.3% 84.3% +<.01%
==========================================
Files 123 123
Lines 14488 14510 +22
==========================================
+ Hits 12214 12233 +19
- Misses 2274 2277 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1558 +/- ##
===========================================
+ Coverage 84.3% 84.39% +0.09%
===========================================
Files 123 124 +1
Lines 14488 14625 +137
===========================================
+ Hits 12214 12343 +129
- Misses 2274 2282 +8
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@JonoYang This PR is for #1439
It is the same code as #1543 but rebased on the latest develop.
#1543 was merged but then reverted because it fails on Windows with infinite recursion as documented in #1555