Add Documentation From Aboutcode - #1812
Merged
pombredanne merged 5 commits intoNov 28, 2019
Merged
Conversation
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
This commit deletes redundant files which is already present in aboutcode. They will be added in the final migration commit. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Migrate all scancode-toolkit documentation from aboutcode till this commit - aboutcode-org/aboutcode@faea9fc Last pull request adding scancode docs was aboutcode-org/aboutcode#33 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Fix broken include and image links to delete "scancode-toolkit/" and update conf.py to point to aboutcode.readthedocs.io by intersphinx Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Member
Author
|
1 Travis Build job failed with "The job exceeded the maximum time limit for jobs, and has been terminated". @MaJuRG Does this happen often? |
steven-esser
suggested changes
Nov 26, 2019
steven-esser
left a comment
Contributor
There was a problem hiding this comment.
Some comments left. There is a lot here, and most of it looks pretty good.
@pombredanne should have some more comments for you, but most of this is ready to go IMO.
Like I mentioned in a previous PR, it is probably better to get this merged in and fix errors later as this volume of changes is difficult to review on GitHub PR interface.
Member
|
@AyanSinhaMahapatra I respun the job. These are totally random flaky failures where the CI flaps for no reason I can fathom. |
steven-esser
approved these changes
Nov 26, 2019
Contributor
|
@pombredanne Anything to add here? |
Member
|
@AyanSinhaMahapatra Thanks. All good and merged! |
AyanSinhaMahapatra
added a commit
to AyanSinhaMahapatra/aboutcode
that referenced
this pull request
Nov 28, 2019
Documentation was migrated via this Pull Request aboutcode-org/scancode-toolkit#1812. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Migrates scancode-toolkit documentation from aboutcode after adding the final improvements/changes via aboutcode-org/aboutcode#33 .
[WIP] Can be Merged after these tasks:
Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com