Skip to content

Upgrade scancode to Python 3.7 and 3.8 - #1819

Closed
Abhishek-Dev09-zz wants to merge 3 commits into
aboutcode-org:developfrom
Abhishek-Dev09-zz:295-deps
Closed

Upgrade scancode to Python 3.7 and 3.8#1819
Abhishek-Dev09-zz wants to merge 3 commits into
aboutcode-org:developfrom
Abhishek-Dev09-zz:295-deps

Conversation

@Abhishek-Dev09-zz

@Abhishek-Dev09-zz Abhishek-Dev09-zz commented Nov 7, 2019

Copy link
Copy Markdown

Upgrade third dependencies for support python 3.7 and python 3.8 .
After merging this we were able to install scancode with python 3.7 and python 3.8 .
Fix #1817

Signed-off-by: Abhishek Kumar abhishek.kasyap09@gmail.com

Signed-off-by: Abhishek Kumar <abhishek.kasyap09@gmail.com>
@Abhishek-Dev09-zz Abhishek-Dev09-zz changed the title Upgrade intbitsit and future to support Python 3.7+ Upgrade scancode to Python 3.7 and 3.8 Nov 8, 2019
Signed-off-by: Abhishek Kumar <abhishek.kasyap09@gmail.com>
@Abhishek-Dev09-zz
Abhishek-Dev09-zz force-pushed the 295-deps branch 5 times, most recently from 2cb7f76 to 7683c54 Compare November 9, 2019 08:32
Signed-off-by: Abhishek Kumar <abhishek.kasyap09@gmail.com>

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ++
This obviously needs also the windows and linux wheels.... but before adding more, would you know if there is way to have one wheel that can run on multiple CPython version (3.6, 3.7 and 3.8?)

Comment thread thirdparty/restructuredtext_lint-1.3.0-cp37-none-any.whl.ABOUT
@Abhishek-Dev09-zz

Copy link
Copy Markdown
Author

Thank you ++
This obviously needs also the windows and linux wheels.... but before adding more, would you know if there is way to have one wheel that can run on multiple CPython version (3.6, 3.7 and 3.8?)

i have already added but we have to verify that its work or not about each wheel.

@steven-esser

Copy link
Copy Markdown
Contributor

@Abhishek-Dev09 @pombredanne What is left to do here? I am interested in getting things working on python37+ environments

@priv-kweihmann

Copy link
Copy Markdown
Contributor

@Abhishek-Dev09 @pombredanne What is left to do here? I am interested in getting things working on python37+ environments

I was about to ask the same - is there any point where a helping hand is needed?

@pombredanne

Copy link
Copy Markdown
Member

@MaJuRG @priv-kweihmann
re:

What is left to do here? I am interested in getting things working on python37+ environments
I was about to ask the same - is there any point where a helping hand is needed?

I am on it. But I want first to push a 3.2 tag ASAP

@ncoghlan

Copy link
Copy Markdown

@pombredanne With the dependencies that use Cython generated code and put it in the sdist, the only way to build against the stable CPython ABI is to update the source module using a Cython 3.0 pre-release that declares CYTHON_LIMITED_API.

@ncoghlan

Copy link
Copy Markdown

@pombredanne I saw that you've switched to the pure Python urlpy fork in #1835. Should this PR be closed in favour of that one? Or are there other wheel updates from this PR that should still be included?

@pombredanne

Copy link
Copy Markdown
Member

@Abhishek-Dev09 since we are taking a slightly different approach for the 3.7 and 3.8 support, I am closing this PR (though you may want to keep the branch around as some of the ABOUT files an wheel may still be things you want to use in our "pseudo" PyPI index?

@pombredanne pombredanne closed this Jul 6, 2020
@pombredanne

Copy link
Copy Markdown
Member

@ncoghlan Re:

I saw that you've switched to the pure Python urlpy fork in #1835. Should this PR be closed in favour of that one? Or are there other wheel updates from this PR that should still be included?

Yes, actually we are also building a public PyPI of pre-built wheel for 3.6/.7/.8.... that can be used to install on systems that do not have the native compilation toolchain machinery on hand and installed.

With the dependencies that use Cython generated code and put it in the sdist, the only way to build against the stable CPython ABI is to update the source module using a Cython 3.0 pre-release that declares CYTHON_LIMITED_API.

Great to know! We may selectively patch and contribute upstream for some packages with native code then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuring with Python 3.7 fails due to no matching distribution found for future>=0.16.0

6 participants