Upgrade scancode to Python 3.7 and 3.8 - #1819
Conversation
Signed-off-by: Abhishek Kumar <abhishek.kasyap09@gmail.com>
55addee to
81e0db2
Compare
Signed-off-by: Abhishek Kumar <abhishek.kasyap09@gmail.com>
2cb7f76 to
7683c54
Compare
Signed-off-by: Abhishek Kumar <abhishek.kasyap09@gmail.com>
7683c54 to
b5a5ebc
Compare
pombredanne
left a comment
There was a problem hiding this comment.
Thank you ++
This obviously needs also the windows and linux wheels.... but before adding more, would you know if there is way to have one wheel that can run on multiple CPython version (3.6, 3.7 and 3.8?)
i have already added but we have to verify that its work or not about each wheel. |
|
@Abhishek-Dev09 @pombredanne What is left to do here? I am interested in getting things working on python37+ environments |
I was about to ask the same - is there any point where a helping hand is needed? |
I am on it. But I want first to push a 3.2 tag ASAP |
|
@pombredanne With the dependencies that use Cython generated code and put it in the sdist, the only way to build against the stable CPython ABI is to update the source module using a Cython 3.0 pre-release that declares |
|
@pombredanne I saw that you've switched to the pure Python urlpy fork in #1835. Should this PR be closed in favour of that one? Or are there other wheel updates from this PR that should still be included? |
|
@Abhishek-Dev09 since we are taking a slightly different approach for the 3.7 and 3.8 support, I am closing this PR (though you may want to keep the branch around as some of the ABOUT files an wheel may still be things you want to use in our "pseudo" PyPI index? |
|
@ncoghlan Re:
Yes, actually we are also building a public PyPI of pre-built wheel for 3.6/.7/.8.... that can be used to install on systems that do not have the native compilation toolchain machinery on hand and installed.
Great to know! We may selectively patch and contribute upstream for some packages with native code then! |
Upgrade third dependencies for support python 3.7 and python 3.8 .
After merging this we were able to install scancode with python 3.7 and python 3.8 .
Fix #1817
Signed-off-by: Abhishek Kumar abhishek.kasyap09@gmail.com