Add OSI License Key Mappings - #1868
Conversation
Signed-off-by: Gaupeng <gaurang.r.rao@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #1868 +/- ##
===========================================
- Coverage 78.64% 78.38% -0.27%
===========================================
Files 131 131
Lines 16809 16925 +116
===========================================
+ Hits 13219 13266 +47
- Misses 3590 3659 +69
Continue to review full report at Codecov.
|
pombredanne
left a comment
There was a problem hiding this comment.
Thanks... I made a few comments ... (and I know this is still a draft.)
Signed-off-by: Gaupeng <gaurang.r.rao@gmail.com>
|
@pombredanne I have updated OSI License Keys for the Licenses that have them. Is this fine? |
Signed-off-by: Gaupeng <gaurang.r.rao@gmail.com>
Signed-off-by: Gaupeng <gaurang.r.rao@gmail.com>
pombredanne
left a comment
There was a problem hiding this comment.
This is looking quite good... I have just a few nit pickings for your review
| @@ -0,0 +1,51 @@ | |||
| import urllib.request | |||
| import licensedcode.index | |||
There was a problem hiding this comment.
This is not used. Also we like to sort the imports
There was a problem hiding this comment.
I'll do the sorting, however, I do use urllib.request to use the OSI APIs to derive the license keys. Also, when I remove the licensedcode.index import, I get a NameError: name 'licensedcode' is not defined error. Should I leave this in?
|
may be some checking by hand of all the "keys" seen in https://www.google.com/search?q=site:https://opensource.org/licenses may help too? |
Signed-off-by: Gaupeng <gaurang.r.rao@gmail.com>
Signed-off-by: Gaupeng gaurang.r.rao@gmail.com
Fixes #1627
Tasks
Run tests locally to check for errors.