Packagedcode to handle Ruby(.gemspec) and Cocoapods(.podspec) by rpotter12 · Pull Request #2075 · aboutcode-org/scancode-toolkit

rpotter12 · 2020-06-18T21:55:12Z

Fixes #2035
Packedcode to handle Ruby(.gemspec) and Cocoapods(.podspec).

Created spec.py file which will extract all the necessary data.
Dependencies are extracted by using gemfileparser.
In this way we don't need to edit any library code.

Tasks

Reviewed contribution guidelines
PR is descriptively titled 📑 and links the original issue above 🔗
Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
Run tests locally to check for errors.
Commits are in uniquely-named feature branch and has no merge conflicts 📁

pombredanne

Thank you .. that looks good overall 👍

But I would like to get @balasankarc https://github.com/balasankarc/gemfileparser take on the license and status of his library.

In general it would be mucho better to maintain a clean fork and push a PR to him and use that gemfileparser as a library IMHO.
Or take over the maintenance of it if that's what @balasankarc wants
So let's wait a bit for him to reply if that works for you!

steven-esser

@rpotter12 I think we

steven-esser

This looks good to me. @pombredanne Anything else to add here?

rpotter12 · 2020-07-07T01:19:33Z

@MaJuRG #2075 (comment) Now nothing is edited from gemfileparser. I have made a different file which will handle gemspec and podspec all the data except dependency and dependencies will be handled by gemfileparser library. So there is no edited code in this PR :)

steven-esser · 2020-07-07T01:28:12Z

@rpotter12 Yeah I see that you have done that change already. Not sure why GH has updated that comment... Anyway, it looks good.

pombredanne

Thank you. Please see my comments inline for your review.

steven-esser

@rpotter12 What is the purpose of the nose dependency you have added?

rpotter12 · 2020-07-10T23:50:43Z

@rpotter12 What is the purpose of the nose dependency you have added?

@MaJuRG Many tests were failing because of it. I think gemfileparser is using nose somewhere but has not mentioned it in the installation file. That's why I have to add that here to get installed. Maybe I have to add this in setup.py file too.

pombredanne

Thank you. See my comments inline.
Also we need to get these resolved:

gemfileparser/gemfileparser#7
gemfileparser/gemfileparser#8 (i really do not care for carying nose around for runtime)
and in all cases we would need ABOUT files.
So let's wait a couple day to leave @balasankarc time to reply and we may fork this instead as https://github.com/nexB/gemfileparser2

rpotter12 · 2020-07-16T01:02:53Z

@pombredanne Please ignore test files and checks for now. checks may be failing as gemfileparser2 has published version

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

pombredanne

All good! Thank you ++ for your preseverance!

rpotter12 force-pushed the gemspec-parser-new branch 2 times, most recently from 97e99d9 to 3382eee Compare June 18, 2020 22:33

rpotter12 requested review from pombredanne and steven-esser June 18, 2020 23:35

rpotter12 mentioned this pull request Jun 19, 2020

Parse Gemspec Files #2035

Closed

pombredanne requested changes Jun 20, 2020

View reviewed changes

Comment thread src/packagedcode/gemspec.py Outdated

Comment thread tests/packagedcode/test_rubygems.py

Comment thread tests/packagedcode/test_rubygems.py

rpotter12 force-pushed the gemspec-parser-new branch 2 times, most recently from 344bcdc to 9a01c46 Compare June 20, 2020 15:08

steven-esser suggested changes Jun 29, 2020

View reviewed changes

Comment thread src/packagedcode/gemspec.py Outdated

rpotter12 force-pushed the gemspec-parser-new branch from 9a01c46 to ae9a3cb Compare July 4, 2020 12:53

rpotter12 requested review from pombredanne and steven-esser July 4, 2020 12:54

rpotter12 force-pushed the gemspec-parser-new branch 4 times, most recently from ed0850a to 157a647 Compare July 5, 2020 15:12

steven-esser approved these changes Jul 7, 2020

View reviewed changes

Comment thread src/packagedcode/gemspec.py Outdated

pombredanne requested changes Jul 8, 2020

View reviewed changes

rpotter12 force-pushed the gemspec-parser-new branch from 6f2626a to 0722eec Compare July 9, 2020 02:12

rpotter12 requested a review from pombredanne July 9, 2020 02:12

steven-esser reviewed Jul 10, 2020

View reviewed changes

pombredanne reviewed Jul 11, 2020

View reviewed changes

Comment thread src/packagedcode/rubygems.py Outdated

pombredanne requested changes Jul 11, 2020

View reviewed changes

rpotter12 force-pushed the gemspec-parser-new branch from b456d9a to 6c4f350 Compare July 13, 2020 08:40

rpotter12 changed the title ~~Packagedcode to handle Ruby(.gemspec) files~~ Packagedcode to handle Ruby(.gemspec) and Cocoapods(.podspec) Jul 13, 2020

rpotter12 force-pushed the gemspec-parser-new branch 2 times, most recently from ee33304 to 1d0acb7 Compare July 13, 2020 09:47

rpotter12 requested a review from pombredanne July 17, 2020 00:44

rpotter12 force-pushed the gemspec-parser-new branch from 000197e to fd1abbe Compare August 4, 2020 12:29

rpotter12 added 15 commits August 4, 2020 18:07

sample gemspec test files

f38f9ed

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

sample pospec test files

9f40f58

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

packagedcode to handle gemspec files

c59e861

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

packagedcode to handle podspec files

c8acc10

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

handle parties

7753719

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

tests code to handle sample gemspec files

7e4594c

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

add thirdparty wheels

d05f223

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

use regex to detect data

e17a44d

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

switch to gemfileparser

74b4b8f

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

detect dependencies

0a5a449

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

remove unexpected failure

95cccd6

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

update vcs url

446ddaa

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

add thirdparty wheels and license

7047452

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

test code for podspec files

7114cda

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

add comma between two packages

c2e044d

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

rpotter12 force-pushed the gemspec-parser-new branch from fd1abbe to c2e044d Compare August 4, 2020 12:37

rpotter12 added 3 commits August 26, 2020 19:02

switch to gemfileparser==0.8.0

c19d2b1

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

Merge branch 'develop' into gemspec-parser-new

b0b9d9a

ignore py2 test

7c10766

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

pombredanne reviewed Aug 26, 2020

View reviewed changes

Comment thread tests/packagedcode/test_rubygems.py Outdated

use pytest to skip py2

cf05a90

Signed-off-by: rpotter12 <rohitpotter12@gmail.com>

rpotter12 requested a review from pombredanne August 26, 2020 15:14

pombredanne approved these changes Sep 3, 2020

View reviewed changes

pombredanne merged commit 31b9d58 into aboutcode-org:develop Sep 3, 2020

This was referenced Sep 3, 2020

Packagedcode to handle .podspec file #2067

Closed

Parse Podspec Files #2036

Closed

AyanSinhaMahapatra mentioned this pull request Jul 30, 2021

Parse podfile.lock and podspec.json files for Cocoapods #2619

Closed

7 tasks

Uh oh!

Uh oh!

Conversation

rpotter12 commented Jun 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tasks

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steven-esser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

steven-esser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rpotter12 commented Jul 7, 2020

Uh oh!

steven-esser commented Jul 7, 2020

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steven-esser left a comment

Choose a reason for hiding this comment

Uh oh!

rpotter12 commented Jul 10, 2020

Uh oh!

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rpotter12 commented Jul 16, 2020

Uh oh!

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rpotter12 commented Jun 18, 2020 •

edited

Loading