Skip to content

Fix docstring for compute_relevance - #2113

Merged
pombredanne merged 1 commit into
aboutcode-org:developfrom
AyanSinhaMahapatra:fix-docstring
Jul 26, 2020
Merged

pombredanne merged 1 commit into
aboutcode-org:developfrom
AyanSinhaMahapatra:fix-docstring

Conversation

@AyanSinhaMahapatra

Copy link
Copy Markdown
Member

Fixes a docstring error, which was explaining the relevance scores
of negative and false positive rules.

Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Fixes a docstring error, which was explaining the relevance scores
of negative and false positive rules.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>

@steven-esser steven-esser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recalling the gitter discussion with @pombredanne, this looks good. I am not super familiar with licensedcode things though.

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pombredanne
pombredanne merged commit 1ccc8d3 into aboutcode-org:develop Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants