Repository navigation
fix include functionality - #2395
Conversation
|
@tardyp Thank you ++ for this! A test should be something to add in https://github.com/nexB/scancode-toolkit/blob/develop/tests/scancode/test_plugin_ignore.py |
|
@tardyp you can also see some of the failing tests here: And the trace details: So this should give a good idea of where to look.
|
When using --include on files, the directories get excluded. removing those ressource end up in removing also the nested files The include exclude algorithm makes it quite difficult to support ignoring a whole directory by just saying ignore=path/to/dir In this version, we support that usecase with ignore=path/to/dir/* Signed-off-by: Pierre Tardy <tardyp@gmail.com>
|
hi @pombredanne Sorry it took so long to update this. I updated the patch and fixed the tests. I am not completely happy with the results as it this algorithm is not supporting the same features. The include exclude algorithm makes it quite difficult to support ignoring a whole directory by just saying ignore=path/to/dir Let me know if you find this acceptable, I'll add a changelog describing this api change. |
|
@pombredanne kindly ping |
pombredanne
left a comment
There was a problem hiding this comment.
Thanks you++
Looking great!
When using --include on files, the directories get excluded.
removing those ressource end up in removing also the
nested files
Not sure exactly which test suite I have to fix.
Would be glad to get some help on this.
Fixes #2059
Tasks
Run tests locally to check for errors.