Add emails and urls to HTML output - #2539
Merged
Merged
Conversation
pombredanne
requested changes
Jun 6, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
Looking good!
Could you add tests too, and a CHANGELOG entry?
pombredanne
requested changes
Jun 15, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
This is looking good but I am not sure that we have a tests that this is effectively working?
You would need to assert something that proves that the data is effectively included.
sritasngh
marked this pull request as draft
August 9, 2021 11:16
sritasngh
marked this pull request as ready for review
August 9, 2021 17:17
pombredanne
reviewed
Aug 13, 2021
pombredanne
approved these changes
Aug 13, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM overall. Thanks!
There is one tiny nit in tests.... but we could merge without this
Add emails and urls in converted_infos. Add holders, authors, emails and urls information in html template. Signed-off-by: Sarita Singh <saritasingh.0425@gmail.com> Co-authored-by: Avinal Kumar <avinal.xlvii@gmail.com>
Signed-off-by: Sarita Singh <saritasingh.0425@gmail.com> Co-authored-by: Avinal Kumar <avinal.xlvii@gmail.com>
Member
|
Thanks! |
pombredanne
reviewed
Aug 13, 2021
Member
Contributor
|
Thanks @pombredanne 😊 |
Contributor
Author
|
Thanks @pombredanne :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add emails and urls in converted_infos. Earlier emails and urls were excluded from infos so these informations weren't fed into html template. Add holders, authors, emails and urls information in html template.
Signed-off-by: Sarita Singh saritasingh.0425@gmail.com
Co-authored-by: Avinal Kumar avinal.xlvii@gmail.com
Partially Solves #1359
Tasks
Run tests locally to check for errors.