Improve copyrights detection - #2590
Merged
Merged
Conversation
This is more explicit and readable Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
We now have correct license numbers returned by copyright and authors detection. Also fix some minor copyright detection issues. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This is required for the new, better and faster copyright detection Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
If there is only a lien trailing with a year, AND or BY we consider the next empty line as part of the copyright statement. Also treat some camel case as JUNK and Module as NN Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Also used in tests Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
- Allow multiline copyright detection with an empty line if ending with a conjunction or a year. - Do not treat Free as an NNP - Better handle leading and trailing comment line markers - Always enable tracing with deep tracing Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Also align setup-mini.cfg with setup.cfg Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne
force-pushed
the
copyrights-improvements
branch
from
July 11, 2021 12:20
e7e6c9e to
acd8b5a
Compare
Member
Author
|
This is all green. Merging now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes several improvement to copyright detection
And other minor improvements